Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/isolate ingest v2 dependencies #3327

Merged
merged 3 commits into from
Jul 2, 2024
Merged

bugfix/isolate ingest v2 dependencies #3327

merged 3 commits into from
Jul 2, 2024

Conversation

rbiseck3
Copy link
Contributor

@rbiseck3 rbiseck3 commented Jul 1, 2024

Description

This PR handles two things:

  • Exposing all the connectors via the connector registries by simply importing the connector module. This should be safe assuming all connector specific dependencies themselves are imported in the methods where they are used and wrapped in @requires_dependencies decorator
  • Remove any import that pulls from the v2 ingest.cli package

@rbiseck3 rbiseck3 force-pushed the roman/fix-dependencies-v2-ingest branch from 930db4f to 7d2c7f2 Compare July 1, 2024 19:02
@rbiseck3 rbiseck3 requested a review from potter-potter July 1, 2024 19:36
potter-potter
potter-potter approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@potter-potter potter-potter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well.

@rbiseck3 rbiseck3 force-pushed the roman/fix-dependencies-v2-ingest branch from 39265da to 85dc8f6 Compare July 2, 2024 13:18
@rbiseck3 rbiseck3 enabled auto-merge July 2, 2024 13:18
@rbiseck3 rbiseck3 added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit c28deff Jul 2, 2024
50 checks passed
@rbiseck3 rbiseck3 deleted the roman/fix-dependencies-v2-ingest branch July 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potter-potter potter-potter potter-potter approved these changes

@vangheem vangheem Awaiting requested review from vangheem

@ahmetmeleq ahmetmeleq Awaiting requested review from ahmetmeleq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbiseck3 @potter-potter